Skip to content

Conversation

yadavan88
Copy link
Contributor

@yadavan88 yadavan88 commented Apr 4, 2025

Add a variable for the scalaCliVersion in the generated BuildInfo

@yadavan88
Copy link
Contributor Author

@Gedochao Here is the PR for adding scala-cli version to buildInfo. Could you please review?

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on some nitpicks.
Also, please include a test.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Gedochao Gedochao merged commit 224f094 into VirtusLab:main Apr 10, 2025
54 checks passed
@yadavan88 yadavan88 deleted the buildinfo-scala-cli-version branch April 10, 2025 12:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants